Our team has came a new project manager who knew a few knowledge in programming, and he always think our team member (most of developers) used to wasting time in a work day, and like to say something likes 'Are you kidding me! You said those simple functions
requires two days to writing, one day is enough', its ok, every manager used say that, but I think his code review method sucks, because he thinks whether or not hard work you are is depends on how many new lines of code you wrote.
Of course I knew the 'public secret' of our team which is 'if he asked you how long you can finish the current working, then told him that the actual requires time * 2 + 2 days' with new rule 'never reuse the code when you can copy it into you current working
as new lines of code', but I am uncomfortable in this way, because I used to wrote code as short as possible, and I don't want to change my not bad habit, also I dislike overtime working, I just want to did my duty and get pay from this, then I can focus on
my own business.
What should I do?
-
-
Your boss is unhappy and you must work harder to keep your job.
Be careful.
-
You should recommand him to see The Daily WTF blog for sure. And hopefully he'll realize LOC is nothing compare to the value of elegent coding style.
Measure work in terms of LOC is a good way to increase the "enterpriseness" of code produced. [6]
-
nDeveloperTime = 2 * 2 + 2 ; // It's a standard.
nHRRecruitmentAndHireTime = 2 * 2 * 2 + nOrientation;
Hmm, I wonder which of those numbers is more? And yeah, the DailyWTF is VERY enlightening for him.
But on the opposite end of the coin, and in all fairness, maybe you all need to peer review with a similar organization to see if your all overestimating your dev times too.
Although copy&paste construction has its merits, when you are copying and pasting others insecure, inefficient, and deprecated code, it only makes matters that much worst.
Good luck.
-
Adenocard wrote:
Although copy&paste construction has its merits, when you are copying and pasting others insecure, inefficient, and deprecated code, it only makes matters that much worst.
I'd not choose to limit on these. Even if secure, efficient, shiningly new code is copied, when copy & pasting here and there, the whole code base would just become unmaintainable.
I seriously doubt that "C&P construction without modification" has any merit other than effectively increasing your LOC. And even "C&P construction with necessary modification" ought to be packing in function/overloading functions to make it organizable.
-
leighsword wrote:...I think his code review method sucks, because he thinks whether or not hard work you are is depends on how many new lines of code you wrote.
...What should I do?
What you should do is find a way to not work for this dim bulb! Honestly, you can't train your manager. If there is a possibility of moving laterally within your company, that may be an answer. If not, get busy looking for a new job.
In the mean time, you should try to give reasonable estimates and deliver tight code, (if you can get away with it.) While it might provide some short-term giddy relief to conspire with your peers to deliver bloated code, it could have the effect of poisoning your soul over time. :O -
Warning: I do not necessarily endorse all of what this post may recommend.
This is a thought: http://mark.phillk.net/movies/Commercials/potatobomb.mov -
Quality not quantity. This could take some time so be patient. This person must be diplomatically lead down the correct path, diplomatic because you are subordinate. How much do you enjoy your job? How loyal are you to the company? Those are important questions because, apparently, after hearing only one side of the story, this supervisor/manager is creating a negative atmosphere, hurting the bottom line, and possiblly being disloyal to the company by enforcing damaging policies. These are ideas that should not be directly confronted to this person. Instead of openly stating these thoughts to him, it may be better to ask questions in a non disrespective way as they come up, ie, phrase your statements or concerns in the form of a question, and in a way that the person you are asking will be motivated to do things the right way.
-
You'll probably have more luck with the potato approach - but OK, if your really love where you work, and you think your boss might be an anomaly, you could try waiting it out. I would say in general that a manager who counts lines of code is a lost cause, and probably has other issues that would prevent him from ever being an effective manager. You have to remember that acting like you respect someone when you don't is manipulative, and can easily back-fire. If the situation is bothering you, then you probably will not be able to play-act your way out of it. Your best bet is still to continue to do good work (if possible) and get yourself out from under this looser boss!
Thread Closed
This thread is kinda stale and has been closed but if you'd like to continue the conversation, please create a new thread in our Forums,
or Contact Us and let us know.