HOLY CRAP I DID IT! - Followup

Post moved here from here. The Source as requested by MikeGoatly.

XML File that is read: Note that only the first item in list is read.

<?xml version="1.0" encoding="utf-8" standalone="yes" ?> 
<feeds>
   <feed>
        <Title>Channel9's Default Feed</Title>
        <UpdateTime>5/11/2005</UpdateTime>
        <FeedURL>http://channel9.msdn.com/rss.aspx</FeedURL>
        <AlternativeURL>http://channel9.msdn.com/rss.aspx</AlternativeURL>
 <ReadOnly>false</ReadOnly>
   </feed>
   <feed>
        <Title>Steve's Feed</Title>
        <UpdateTime>5/11/2005</UpdateTime>
        <FeedURL>ttp://www.xblogs.org/blog/steve/rss.aspx</FeedURL>
        <AlternativeURL>http://www.xblogs.org/blog/steve/rss.aspx</AlternativeURL>
 <ReadOnly>false</ReadOnly>
   </feed>
</feeds>

I suspect you're only getting the last feed out at the end, right?

You're looping through all the nodes and populating a single instance of Subscription.

When you hit a "feed" node, you'll want to create a new Subscription struct for population and push the current one onto the current subscriptions array (assuming it's not the first feed you've encountered - subscription will be empty in this case)

No, only the first. Let me do that right now, one moment.

Dude - sorry - didn't follow the codepath through properly - the reason you were only getting the first in your original code is the use of break rather than continue in your "ReadOnly" case.

EDIT: Note that you'll still need to create a new subscription struct at some point

I tried continue before i converted the object to boolean, but it still returned only one item.

Yeah, if you continue from the ReadOnly case, I think you'll get the last subscription in the XML because you'll just keep looping through the XML updating the same subscription struct (i.e. what I thought was happening in my first scan of the code)

MikeGoatly wrote:

Yeah, if you continue from the ReadOnly case, I think you'll get the last subscription in the XML because you'll just keep looping through the XML updating the same subscription struct (i.e. what I thought was happening in my first scan of the code)

Any chance you can update the source file so I can have another look-see?

MikeGoatly wrote:

Any chance you can update the source file so I can have another look-see?

Ok matey, what you need to do is put this as the else statement for the if (node.NodeType==XmlNodeType.Element) statement:

else if (reader.NodeType == XmlNodeType.EndElement)
        {
         //Closing feed tag - add the subscription at this point
         if (reader.Name=="feed")
         {
            // if successfull, give it the go to add into each feed into our subscription structure.
                               TheCurrentSubscriptions.Add(subscription);
        //Create a new subscription so we don't get any previous data mixed with the new record
        subscription = new Subscription();
         }
        }

And get rid of the existing TheCurrentSubscriptions.Add(subscription); line from the loop.

Other comments:
You'll need to move the reader.Close() method call to after the while loop - it won't always be called at the moment.
You don't really need the break statement at line 131 (after the current reader.Close()) because what this will do is cause your code to quit early if you encounter an unexpected node.  What I'd do is put a default case on the switch statement and call System.Diagnostics.Debug.Fail to let me know something unusual has happened.

Hope that helps...

Thanks alot! I will try that