Comment Feed for Event disposal (TechOff on Channel 9)

Re: Event disposal

Massif — Tue, 11 Apr 2006 12:37:06 GMT

Is any of that strictly necessary?

Wouldn't the garbage collector destroy the object regardless of whether anything was listening for the events? I can't see why the GC wouldn't destroy your object - unless a subscriber holds a reference to the object to which it is subscribed. Which would be stupid - and against the whole point of events in the first place.

In which case what do you gain? I can't see any benefit - and if you want to know when an object has been disposed of, then you could just add an event to tell you. In fact how would this help in that case either?

Re: Event disposal

pauldaly1982 — Mon, 10 Apr 2006 19:53:51 GMT

I'm still interested in learning more about how this code works. Can you 1) provide a sample application and 2) explain how this could be used to handle delegates. Does GetEvents() return an instance's delegates as well?

Thanks,

Paul

Re: Event disposal

pauldaly1982 — Tue, 14 Mar 2006 13:57:22 GMT

I'm interested in how this code works. Do you mind adding some more comments and/or add a dummy class that inherits from your BaseObject class.

Will this remove user created events (not just the default events that are available with the control)?

Thanks,

- Paul

Re: Event disposal

ilya — Mon, 09 Jan 2006 14:21:10 GMT

makemaster wrote:

Good work ilya! You certainly solved my problem.

No problem, it's nice to know that this has helped someone. :D

Re: Event disposal

makemaster — Mon, 09 Jan 2006 13:22:16 GMT

Good work ilya! You certainly solved my problem.

Re: Event disposal

ilya — Fri, 06 Jan 2006 17:57:38 GMT

Well I don't know if anyone is interested in this but I have finally found a solution for this.

public class BaseObject
{
public event EventHandler Event1;
private BindingFlags flags = BindingFlags.NonPublic |BindingFlags.Instance | BindingFlags.Public;

public BaseObject(){}

   public void ReleaseEvents()
   {
   //Get all of the events and then use the    DeclaringType    property to get the instance of the fields
   EventInfo[] events = this.GetType().GetEvents(flags);
   if(events == null)
      return;
   if(events.Length < 1)
      return;

//Store All the FieldInfo objects in a HashTable
System.Collections.Hashtable ht = new System.Collections.Hashtable();

   for(int i = 0; i < events.Length; i++)
   {
      //Get all of the fields for the selected declared type
      FieldInfo[] fields = events[i].DeclaringType.GetFields(flags);
      foreach(FieldInfo fi in fields)
      {
         if(events[i].Name.Equals(fi.Name) && !ht.Contains(fi.Name))
         ht.Add(fi.Name,fi);
      }
   }

   System.Collections.IDictionaryEnumerator en = ht.GetEnumerator();
   while(en.MoveNext())
   {
      FieldInfo f = en.Value as FieldInfo;
      MulticastDelegate e = f.GetValue(this) as MulticastDelegate;
      if(e != null)
      {
         foreach(Delegate del in e.GetInvocationList())
         {
            getEvent(f.Name,f.DeclaringType).GetRemoveMethod().Invoke(this,new object[]{del});
         }
      }
   }
}
private EventInfo getEvent(string name, Type t)
{
   if(name == null)
      return null;
   if(t == null)
      return null;

   return t.GetEvent(name,flags);
}

public string Name
{
   get{return Guid.NewGuid().ToString();}
   set
      {
         Event1(this,null);
      }
}

Re: Event disposal

Andrew Webber FX — Thu, 05 Jan 2006 22:03:57 GMT

ilya wrote:

1) Sometimes I will want to know if an object is being deleted/disposed because I am listening for that also...

on a slippery slope with that kinda requirement in the managed world... i would just use VC++.NET 2005 and delete the managed object, makes me feel better, but even then you wouldnt put a mortgage on it not being around.:P

Re: Event disposal

ilya — Thu, 05 Jan 2006 21:49:24 GMT

ScanIAm wrote:

ilya wrote:
If you read what i wrote above "I don't want to explicitly specify/set the events to null for every object"
Reason being is that if I have a lot of objects that I will create that will inherit from the BaseObject I don't want to specifically set the Event Fields to null. Especially during the call to the Dispose method I want to be able to call this "ReleaseEvents" method to unhook all the event starting from the BaseObject and all the way up the Inheritance chain.

1) There is no reason for you to have to null out your events. The subscribers will not know that your object has disappeared nor will they care.

2) If you do decide to set the events to null, you should simply clear the events that are explicitly created by the child object in the code. Then call the parent dispose function. This is called inheritance.

3) See #1. You are wasting your time worrying about this.

1) Sometimes I will want to know if an object is being deleted/disposed because I am listening for that also.
2) Once again I'll say it, I don't want to explicitly remove event handlers from the child objects because I might have a lot of them and in the future people might add more objects and if that happends I don't want them to be responsible for removing event handlers.
3) I just wanted to know if there is a good way that people know about to do this, but if no one really knows then I will have to come up with my own way of doing this.

Re: Event disposal

ScanIAm — Thu, 05 Jan 2006 21:35:11 GMT

ilya wrote:

If you read what i wrote above "I don't want to explicitly specify/set the events to null for every object"
Reason being is that if I have a lot of objects that I will create that will inherit from the BaseObject I don't want to specifically set the Event Fields to null. Especially during the call to the Dispose method I want to be able to call this "ReleaseEvents" method to unhook all the event starting from the BaseObject and all the way up the Inheritance chain.

1) There is no reason for you to have to null out your events. The subscribers will not know that your object has disappeared nor will they care.

2) If you do decide to set the events to null, you should simply clear the events that are explicitly created by the child object in the code. Then call the parent dispose function. This is called inheritance.

3) See #1. You are wasting your time worrying about this.

Re: Event disposal

ilya — Thu, 05 Jan 2006 19:08:51 GMT

If you read what i wrote above "I don't want to explicitly specify/set the events to null for every object"
Reason being is that if I have a lot of objects that I will create that will inherit from the BaseObject I don't want to specifically set the Event Fields to null. Especially during the call to the Dispose method I want to be able to call this "ReleaseEvents" method to unhook all the event starting from the BaseObject and all the way up the Inheritance chain.

Re: Event disposal

sprayer — Thu, 05 Jan 2006 17:30:47 GMT

You dont need to explicitly remove each event handler.

Here is an example of the Dispose & Event pattern.

// Design pattern for a base class.
public class Base: IDisposable
{
   public event EventHandler BaseEvent;

   protected virtual void OnBaseEvent()
   {
      if (BaseEvent != null)
      {
         BaseEvent(this, EventArgs.Empty);
      }
   }

   //Implement IDisposable.
   public void Dispose()
   {
     Dispose(true);
      GC.SuppressFinalize(this);
   }

   protected virtual void Dispose(bool disposing)
   {
      if (disposing)
      {
         // Free other state (managed objects).
         if (BaseEvent != null)
         {
            BaseEvent = null;
         }
      }
      // Free your own state (unmanaged objects).
      // Set large fields to null.
   }

   // Use C# destructor syntax for finalization code.
   ~Base()
   {
      // Simply call Dispose(false).
      Dispose (false);
   }

// Design pattern for a derived class.
public class Derived: Base
{
   public event EventHandler DerivedEvent;

   protected virtual void OnDerivedEvent()
   {
      if (DerivedEvent != null)
      {
         DerivedEvent(this, EventArgs.Empty);
      }
   }

   protected override void Dispose(bool disposing)
   {
      if (disposing)
      {
         // Release managed resources.
         if(DerivedEvent != null)
         {
            DerivedEvent = null;
         }
      }
      // Release unmanaged resources.
      // Set large fields to null.
      // Call Dispose on your base class.
      base.Dispose(disposing);
   }
   // The derived class does not have a Finalize method
   // or a Dispose method with parameters because it inherits
   // them from the base class.
}

Re: Event disposal

ilya — Thu, 05 Jan 2006 16:56:26 GMT

sprayer wrote:

Follow the Finalize & Dispose pattern

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cpgenref/html/cpconFinalizeDispose.asp

At the URL there is an example of a implementing Dispose in a Base-Derived class.

Tip:
If your are using VS2005 you can create a Dispose Snippet to speed up the process and do most of the work for you.

Later
sprayer

The only problem is that I don't want to explicitly specify the removal of every event starting from the BaseObject all the way up the Inheritance chain.

Re: Event disposal

sprayer — Thu, 05 Jan 2006 16:37:57 GMT

Follow the Finalize & Dispose pattern

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cpgenref/html/cpconFinalizeDispose.asp

At the URL there is an example of a implementing Dispose in a Base-Derived class.

Tip:
If your are using VS2005 you can create a Dispose Snippet to speed up the process and do most of the work for you.

Later
sprayer

Re: Event disposal

ilya — Thu, 05 Jan 2006 16:29:19 GMT

sprayer wrote:

Yes it is recommended to unhook your events in your dispose. Just set your event to null in your base class dispose method. Make sure you use the Dispose pattern.

Later

sprayer

That will work in my BaseObject class, but what if another class is inheriting from the BaseObject class and it has it's own events? I want to be able to call one method in my BaseObject class and dispose all the events starting from the BaseObject all the way up to the class that is inheriting from the BaseObject. I was trying to do this with Reflection but was not successful.

Re: Event disposal

ilya — Thu, 05 Jan 2006 16:24:39 GMT

blowdart wrote:

Calling a dispose method does not release the object to the garbage collector, regardless of what you do inside that object.

Well what I ment is that if the object is not being used then the Garbage collection will remove that object, but if that object is referencing another object and in this case an event then I think that the Garbage Collector will not dispose this object. So what I am looking for is the best way of unhooking the references for all of events inside of the object.

Re: Event disposal

sprayer — Thu, 05 Jan 2006 16:22:53 GMT

Yes it is recommended to unhook your events in your dispose. Just set your event to null in your base class dispose method. Make sure you use the Dispose pattern.

Later

sprayer

Re: Event disposal

blowdart — Thu, 05 Jan 2006 16:19:11 GMT

Calling a dispose method does not release the object to the garbage collector, regardless of what you do inside that object.